Re: [PATCH 2/2] target/user: Do not set unused fields in tcmu_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

Just curious would this patch solve vpd page 83 issue of TCMU?

Thanks!

--Sheng

On Fri, Oct 9, 2015 at 11:41 AM, Andy Grover <agrover@xxxxxxxxxx> wrote:
> TCMU sets TRANSPORT_FLAG_PASSTHROUGH, so INQUIRY commands will not be
> emulated by LIO but passed up to userspace. Therefore TCMU should not
> set these, just like pscsi doesn't.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
>  drivers/target/target_core_user.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 41f9eb0..5e6d6cb 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1101,8 +1101,6 @@ tcmu_parse_cdb(struct se_cmd *cmd)
>
>  static const struct target_backend_ops tcmu_ops = {
>         .name                   = "user",
> -       .inquiry_prod           = "USER",
> -       .inquiry_rev            = TCMU_VERSION,
>         .owner                  = THIS_MODULE,
>         .transport_flags        = TRANSPORT_FLAG_PASSTHROUGH,
>         .attach_hba             = tcmu_attach_hba,
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux