Hi David, On Fri, 2 Oct 2015 16:22:29 +0200, David Disseldorp wrote : > This patch-set allows for the modification of the T10 Vendor > Identification string returned in the SCSI INQUIRY response, via the > target/core/$backstore/$name/wwn/vendor_id ConfigFS path. Your patch is a welcome addition: I believe a lot of storage vendors that rely on LIO carry a patch to change the vendor ID. I tested your patch set and I think it does not work as expected when the vendor ID length is 8 characters: # echo -n "1234567" > /sys/kernel/config/target/core/iblock_0/block1/wwn/vendor_id # cat /sys/kernel/config/target/core/iblock_0/block1/wwn/vendor_id T10 Vendor Identification: 1234567 # echo -n "12345678" > /sys/kernel/config/target/core/iblock_0/block1/wwn/vendor_id sh: write error: Value too large for defined data type According to http://www.t10.org/ftp/t10/vendorid.txt, "The Vendor ID code shall be 8 or fewer ASCII graphic characters" and I see some vendor names in the list that are 8 characters long. With best regards, -- Christophe Vu-Brugier -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
