On Wed, 30 Sep 2015 10:49:42 -0700, Andy Grover wrote: > > Sure we could make this a compile-time option, but that would require > > everyone building a storage appliance to recompile the module/kernel. > > Which is not what we as an OS vendor would want. > > (And I guess RH will have the same opinion wrt rebuilding kernel modules > > ...) > > Ah, true. > > And, having it in configfs means userspace can read it easily. > > Do we need to worry about what happens if vendor id changes at runtime, > for already-exported luns? Or can we just assume nobody would try that? Like the VPD Unit Serial, changes to the vendor id are blocked while the device is exported by a TPG. > Would there be any benefit in making this a per-target, per-tpg, or > per-lun attribute? (I can't think of any but wanted to raise the question.) My preference would be to keep it per-device, given that many of the other INQUIRY fields can be configured in a similar way. Thanks for the feedback Andy. Cheers, David -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
