Hi Christophe,
On Tue, 2015-09-22 at 11:14 +0200, Christophe Vu-Brugier wrote:
> Hi Nicholas and Dragan,
>
> On Thu, 17 Sep 2015 23:48:30 -0700, Nicholas A. Bellinger wrote :
> > > > Sep 17 02:08:08 storage kernel: Got unknown iSCSI OpCode: 0x43
> > > > Sep 17 02:08:08 storage kernel: Cannot recover from unknown opcode while ERL=0, closing iSCSI connection.
> > > >
> > > >
> > > > Taking a look at this now.
> > >
> > > Thanks
> >
> > I'm able to reproduce with v4.3-rc1 code.
> >
> > Note this bug is not specific to MC/S operation, and appears to be a
> > regression specific to MSFT iSCSI initiators.
> >
> > Still debugging this, but should have a bug-fix soon.
> >
> > Thanks alot for reporting this.
>
> I performed a git bisect between Linux v4.1 and v4.2 and the bad commit
> is one of my commits:
>
> c04a609 iscsi-target: remove support for obsolete markers
>
> I am looking at the issue right now.
>
> With best regards,
>
Thanks much for bisecting this bug down to v4.2 code.
The following patch to avoid sending IFMarker/OFMarker = No keys (by
default) unless requested by initiator should get MSFT + open-iscsi
working for both cases.
Please verify.
diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_param
index e8a52f7..718e9f7 100644
--- a/drivers/target/iscsi/iscsi_target_parameters.c
+++ b/drivers/target/iscsi/iscsi_target_parameters.c
@@ -496,9 +497,9 @@ int iscsi_set_keys_to_negotiate(
} else if (!strcmp(param->name, SESSIONTYPE)) {
SET_PSTATE_NEGOTIATE(param);
} else if (!strcmp(param->name, IFMARKER)) {
- SET_PSTATE_NEGOTIATE(param);
+ SET_PSTATE_REJECT(param);
} else if (!strcmp(param->name, OFMARKER)) {
- SET_PSTATE_NEGOTIATE(param);
+ SET_PSTATE_REJECT(param);
} else if (!strcmp(param->name, IFMARKINT)) {
SET_PSTATE_REJECT(param);
} else if (!strcmp(param->name, OFMARKINT)) {
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
