On 09/04/2015 12:41 PM, Mike Christie wrote:
Hey Nick and Christoph, For the target_core_iblock + rbd/COMPARE_AND_WRITE support approach, I still need a patch like below to be able to allow target_core_iblock.c to be able to specify specific codes like TCM_MISCOMPARE_VERIFY. Is the patch below ok? I made it work similar to how we have other completion functions, target_complete_cmd_with_*, that take in extra amounts of info like length or sense. Instead, I can modify target_complete_cmd and all the callers so they just take/pass the sense and info if needed: void target_complete_cmd(struct se_cmd *cmd, u8 scsi_status, sense_reason_t sense, u32 info)
We also want user/pscsi passthrough to be able to return correct sense info, and your patch would let them do this.
-- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html