Based on hch's suggestion, move away from storing textual representations of IP and port in favor of storing struct sockaddr_storage, which can then be printed as needed using %pISc or %pISpc prink formats. The first patch fixes the double-brackets issue, I tested it separately and recommend @stable. The following patches replace other spots in a similar manner, and then switch all usage of __kernel_sockaddr_storage to the shorter equivalent, sockaddr_storage. Andy Grover (4): target/iscsi: Fix np_ip bracket issue by removing np_ip target/iscsi: Keep local_ip as the actual sockaddr target/iscsi: Replace conn->login_ip with login_sockaddr target/iscsi: Replace __kernel_sockaddr_storage with sockaddr_storage drivers/infiniband/ulp/isert/ib_isert.c | 29 ++--------- drivers/target/iscsi/iscsi_target.c | 49 +++++++----------- drivers/target/iscsi/iscsi_target.h | 6 +-- drivers/target/iscsi/iscsi_target_configfs.c | 22 ++++---- drivers/target/iscsi/iscsi_target_login.c | 76 ++++++++++++++-------------- drivers/target/iscsi/iscsi_target_login.h | 4 +- drivers/target/iscsi/iscsi_target_stat.c | 2 +- drivers/target/iscsi/iscsi_target_tpg.c | 19 ++++--- drivers/target/iscsi/iscsi_target_tpg.h | 2 +- drivers/target/iscsi/iscsi_target_util.c | 32 ++++++++++-- include/target/iscsi/iscsi_target_core.h | 10 ++-- include/target/iscsi/iscsi_target_stat.h | 2 +- include/target/iscsi/iscsi_transport.h | 2 +- 13 files changed, 121 insertions(+), 134 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
