On 08/20/2015 12:27 AM, Christoph Hellwig wrote:
On Wed, Aug 19, 2015 at 06:22:52PM -0700, Andy Grover wrote:
Revert commit 1997e6259, which just papers over the issue and causes
double brackets on ipv6 inaddr_any address.
Now, both addresses via conn->local_ip and np->np_ip for ipv6 are kept
in bracketed format.
Change lio_target_call_addnptotpg() to pass bracketed ipv6 address to
iscsit_tpg_add_network_portal. Alas, we need to rebuild the bracketed
string at the end because we need unbracketed for in6_pton().
Fix and extend some comments earlier in the function.
Tested to work for :: and ::1 via iscsiadm, previously :: failed, see
https://bugzilla.redhat.com/show_bug.cgi?id=1249107 .
Why do we even need these ASCII local_ip and np_ip variables? Shouldn't
we just store the sockaddrs only and then use the right printk specifier
to print it when we need the ASCII form, e.g. pISpc in
iscsit_build_sendtargets_response?
Good point. I'll take a look at that this afternoon.
But you're ok with this fix for @stable, I'm hoping.
Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
