Hi Spencer & Co, On Wed, 2015-08-12 at 23:05 -0700, Spencer Baugh wrote: > From: Roland Dreier <roland@xxxxxxxxxxxxxxx> > > REPORT LUNS should not fail just because the allocation length is less > than 16. The relevant section of SPC-4 is: > > 4.2.5.6 Allocation length > > The ALLOCATION LENGTH field specifies the maximum number of bytes or > blocks that an application client has allocated in the Data-In > Buffer. The ALLOCATION LENGTH field specifies bytes unless a > different requirement is stated in the command definition. > > An allocation length of zero specifies that no data shall be > transferred. This condition shall not be considered an error. > > So we should just truncate our response rather than return an error. > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> > Signed-off-by: Spencer Baugh <sbaugh@xxxxxxxxxx> This patch looks fine, but it currently doesn't apply to target-pending/master code due Roland's earlier patch: target: REPORT LUNS should return LUN 0 even for dynamic ACLs https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?id=9c395170a559d3b23dad100b01fc4a89d661c698 Would you be so kind to respin atop current target-pending/master..? Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
