On Tue, 2015-07-21 at 15:39 +0200, Christoph Hellwig wrote:
> On Mon, Jul 20, 2015 at 12:16:01AM +0200, Sebastian Herbszt wrote:
> > Fix build breakage and set the protocol identifier based on the parameter.
> >
> > Fixes: 9ac8928e6a3e ("target: simplify the target template registration API")
> > Fixes: e4aae5af810e ("target: change core_tpg_register prototype")
> >
> > Signed-off-by: Sebastian Herbszt <herbszt@xxxxxx>
>
> Looks good, thanks!
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
Applied. Thanks for fixing this up Sebastian.
> But:
>
> > + if proto_ident == "FC":
> > + buf += " ret = core_tpg_register(wwn, &tpg->se_tpg, SCSI_PROTOCOL_FCP);\n"
> > + elif proto_ident == "SAS":
> > + buf += " ret = core_tpg_register(wwn, &tpg->se_tpg, SCSI_PROTOCOL_SAS);\n"
> > + elif proto_ident == "iSCSI":
> > + buf += " ret = core_tpg_register(wwn, &tpg->se_tpg, SCSI_PROTOCOL_ISCSI);\n"
>
> Nic, do you think it might be time to jus kill these FC/SAS/iSCSI branches
> off? If people write a new target it's probably neither of those, and
> even if it is they tend to add some weird boilerplate code. Maybe
> it should just generate a real minimal stub?
Sure. SCSI_PROTOCOL_UNSPEC for the generated module would probably make
the most sense, along with a FIXME comment for the author to fill in the
appropriate bit.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
