Re: [PATCH 1/2] target: Remove cmd->se_ordered_id (unused except debug log lines)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 21, 2015 at 05:45:32PM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> For every command, we set se_ordered_id by doing atomic_inc_return on
> dev->dev_ordered_id for the corresponding device.  However, the only
> places this value gets used are in pr_debug() calls, which doesn't
> seem worth an extra atomic op per IO.
> 
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Btw, does anyone have a strong argument for even keepig the order tag
support at all?  It actually can reorder commands in various cases, so
pretending it's fully ordered seems dangerous to me.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux