On Tue, Jul 14, 2015 at 02:25:50PM -0500, Steve Wise wrote: > if (device_supports_fastreg && device_supports_signature) > use FRMR > else > use DMAMR > > Shouldn't we just recode it this way? > > if (device_supports_fastreg) > use FRMR > else > use DMAMR How does IB_DEVICE_LOCAL_DMA_LKEY (and ->local_dma_lkey) play into this? Seems like that should be the preferred option if supported. Interestingly enough various iWarp driver seem to support this option, what's the story behind that? The (to me surprising) conclusion on the list was that iWarp would always need a memory regireations that also allows remove writes even for lkeys, but from looking at the users of IB_DEVICE_LOCAL_DMA_LKEY / local_dma_lkey that seem to prefer that over creating a MR. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
