On 7/8/2015 1:19 PM, Christoph Hellwig wrote:
On Mon, Jul 06, 2015 at 04:15:08PM +0300, Sagi Grimberg wrote:
PI errors should be reported in a descriptor format sense data.
Fix that by adding a desc_format flag to struct sense_info and pass
it to scsi_build_sense_buffer() to do the right thing.
Do we really need the additional flag? We only need the descriptor
sense format because we add the sector information. So just checking
for that should be enough, especially when paired with a comment
explaining that logic in the source file.
We don't have any other information today, but sector is not the only
information that is requires a descriptor format, so maybe it will be a
bit awkward to condition the descriptor format on the sector info?
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
