Hello Andy Grover,
The patch 9c1cd1b68cd1: "target/user: Only support full command
pass-through" from May 19, 2015, leads to the following static
checker warning:
drivers/target/target_core_user.c:1008 tcmu_set_configfs_dev_params()
warn: perhaps use 'kstrtouint()' for 'tmp_ul'
drivers/target/target_core_user.c
992 case Opt_hw_block_size:
993 arg_p = match_strdup(&args[0]);
994 if (!arg_p) {
995 ret = -ENOMEM;
996 break;
997 }
998 ret = kstrtoul(arg_p, 0, &tmp_ul);
999 kfree(arg_p);
1000 if (ret < 0) {
1001 pr_err("kstrtoul() failed for hw_block_size=\n");
1002 break;
1003 }
1004 if (!tmp_ul) {
Since "tmp_ul" can be 64 bits and ->hw_block_size is 32 then it's simple
enough to arrange for ->hw_block_size to be zero. But we don't divide
by it, so I don't know if it matters...
1005 pr_err("hw_block_size must be nonzero\n");
1006 break;
1007 }
1008 dev->dev_attrib.hw_block_size = tmp_ul;
1009 break;
1010 default:
1011 break;
1012 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
