Re: [PATCH 02/21] target: Do not hold session command lock around command destructor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/21/15 10:34, Christoph Hellwig wrote:
On Wed, May 20, 2015 at 02:51:04PM +0200, Bart Van Assche wrote:
This patch fixes the following kernel warning because it avoids that
IRQs are disabled while ft_release_cmd() is invoked (fc_seq_set_resp()
invokes spin_unlock_bh()):

I don't really understand how this mitigates the issue that
ccf5ae8 ("target: close target_put_sess_cmd() vs. core_tmr_abort_task() race")
fixed by taking the lock earlier.

But to me it seems like that issue should be fixed by switching
core_tmr_abort_task to use kref_get_unless_zero instead.

Hello Christoph,

Maybe I should move that patch to a later point in this series. A later patch namely removes the kref_get() and kref_put() calls from core_tmr_abort_task().

Bart.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux