On Wed, May 20, 2015 at 02:51:46PM +0200, Bart Van Assche wrote: > Make transport_wait_for_tasks() use a completion that has been > allocated on the stack instead of the t_transport_stop_comp member > of struct se_cmd. Introduce a callback mechanism in struct se_cmd. > > This is a first step towards removing the t_transport_stop_comp > member. That member variable cannot yet be removed via this patch > because the tcm_qla2xxx driver uses it directly. I don't really like the indirection very much. I'd much prefer to just turn t_transport_stop_comp into a pointer to the on-stack completion, and do something similar for the other completions. Saner names for the members would still be welcome, though. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
