Re: [PATCH] target: Simplify LUN shutdown code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-05-19 at 16:16 +0200, Bart Van Assche wrote:
> Instead of starting a thread from transport_clear_lun_ref() that
> waits for LUN shutdown, wait in that function for LUN shutdown
> to finish. Additionally, change the return type of
> transport_clear_lun_ref() from int to void.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> ---
>  drivers/target/target_core_device.c    |  1 -
>  drivers/target/target_core_internal.h  |  2 +-
>  drivers/target/target_core_tpg.c       |  2 --
>  drivers/target/target_core_transport.c | 23 +----------------------
>  include/target/target_core_base.h      |  1 -
>  5 files changed, 2 insertions(+), 27 deletions(-)
> 

The separate process context for LUN shutdown was originally required
with pre se_lun->lun_ref code, where spin_lock_irqsave() was acquired +
released when walking a list of commands to shutdown.

Since that's gone now, dropping the separate process context is fine.

Applied to for-next, with a bit of fuzz around the lun_sep_lock removal.

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux