On Mon, May 18, 2015 at 11:51:39AM -0700, Andy Grover wrote: > After much discussion, give up on only passing a subset of SCSI commands > to userspace and pass them all. Based on what pscsi is doing, make sure > to set SCF_SCSI_DATA_CDB for I/O ops. Can you just move the pscsi parse_cdb function to common code as passthrough_parse_cdb, similar to what I did for the fabric attributes? > > Base dev attribs off pscsi but remove hw_pi_prot_type. Make hw_block_size > configurable via dev param. Why? This should behave exactly the same as pscsi. In fact if you look at for next you'll have a premade set of attributes so keeping them in sync for the pass through case would be useful. > > Add some missing SCSI opcodes to scsi/scsi.h as needed. Can you drop this for now? Bart has a patch series moving this around, and this would create unessecary conflicts. Just use the numeric value for now. Otherwise this looks fine. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
