On Wed, 2015-05-13 at 09:17 +0200, Bart Van Assche wrote: > The function transport_complete_qf() must call either > queue_data_in() or queue_status() but not both. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > --- > drivers/target/target_core_transport.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > index cf010a5..f7ab818 100644 > --- a/drivers/target/target_core_transport.c > +++ b/drivers/target/target_core_transport.c > @@ -1952,8 +1952,7 @@ static void transport_complete_qf(struct se_cmd *cmd) > case DMA_TO_DEVICE: > if (cmd->se_cmd_flags & SCF_BIDI) { > ret = cmd->se_tfo->queue_data_in(cmd); > - if (ret < 0) > - break; > + break; > } > /* Fall through for DMA_TO_DEVICE */ > case DMA_NONE: Applied to target-pending/master. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html