On Mon, 2015-05-04 at 16:57 +0200, Bart Van Assche wrote: > On 05/03/15 04:00, Nicholas A. Bellinger wrote: > > On Tue, 2015-04-14 at 13:26 +0200, Bart Van Assche wrote: > >> Simplify target core and target drivers by storing the task tag > >> a.k.a. command identifier inside struct se_cmd. > >> > >> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > >> Cc: Christoph Hellwig <hch@xxxxxx> > >> Cc: Andy Grover <agrover@xxxxxxxxxx> > >> Cc: Sagi Grimberg <sagig@xxxxxxxxxxxx> > >> Cc: <qla2xxx-upstream@xxxxxxxxxx> > >> Cc: Felipe Balbi <balbi@xxxxxx> > >> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> > >> Cc: Juergen Gross <jgross@xxxxxxxx> > >> --- > >> Documentation/target/tcm_mod_builder.py | 8 ----- > >> drivers/infiniband/ulp/srpt/ib_srpt.c | 35 +++++++------------ > >> drivers/infiniband/ulp/srpt/ib_srpt.h | 1 - > >> drivers/scsi/qla2xxx/qla_target.c | 52 ++++++++++++---------------- > >> drivers/scsi/qla2xxx/qla_target.h | 1 - > >> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 11 ------ > >> drivers/target/iscsi/iscsi_target.c | 1 + > >> drivers/target/iscsi/iscsi_target_configfs.c | 9 ----- > >> drivers/target/loopback/tcm_loop.c | 10 +----- > >> drivers/target/sbp/sbp_target.c | 12 ++----- > >> drivers/target/target_core_configfs.c | 4 --- > >> drivers/target/target_core_tmr.c | 6 ++-- > >> drivers/target/target_core_transport.c | 33 +++++++++--------- > >> drivers/target/target_core_xcopy.c | 7 +--- > >> drivers/target/tcm_fc/tcm_fc.h | 1 - > >> drivers/target/tcm_fc/tfc_cmd.c | 10 +----- > >> drivers/target/tcm_fc/tfc_conf.c | 1 - > >> drivers/usb/gadget/legacy/tcm_usb_gadget.c | 36 +++++++------------ > >> drivers/usb/gadget/legacy/tcm_usb_gadget.h | 1 - > >> drivers/vhost/scsi.c | 7 +--- > >> drivers/xen/xen-scsiback.c | 10 +----- > >> include/target/target_core_base.h | 1 + > >> include/target/target_core_fabric.h | 1 - > >> 23 files changed, 76 insertions(+), 182 deletions(-) > >> > > > > Applied to target-pending/for-next with a bit of patch fuzz due to other > > upstream changes. > > Hello Nic, > > Would it be possible to squash the patch below onto what is already in > your for-next branch ? The patch below addresses Christoph's review > comments. > > Thanks, > > Bart. > > Subject: [PATCH] target: Address task tag review comments > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > --- > drivers/target/iscsi/iscsi_target.c | 1 + > drivers/usb/gadget/legacy/tcm_usb_gadget.c | 25 +++++++++++++------------ > drivers/usb/gadget/legacy/tcm_usb_gadget.h | 1 + > 3 files changed, 15 insertions(+), 12 deletions(-) Applied and squashed into patch #2. Thanks Bart. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html