On Sun, 2015-05-03 at 08:54 +0200, Christoph Hellwig wrote:
> The only instance of ->put_session is in qla2xxx, and was added by commit
> aaf68b ("tcm_qla2xxx: Convert to TFO->put_session() usage") with the following
> description:
>
> This patch converts tcm_qla2xxx code to use an internal kref_put() for
> se_session->sess_kref in order to ensure that qla_hw_data->hardware_lock
> can be held while calling qlt_unreg_sess() for the final put.
>
> But these day we're already holding the hardware lock over qlt_unreg_sess in
> the ->close_session callback, so we're fine without this method.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 19 -------------------
> drivers/target/target_core_transport.c | 6 ------
> drivers/xen/xen-scsiback.c | 1 -
> include/target/target_core_fabric.h | 1 -
> 4 files changed, 27 deletions(-)
Looks fine.
Applied after re-adding tcm_qla2xxx_release_session, and dropping
left-over put_session usage.
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
