On Mon, May 04, 2015 at 12:40PM, Andy Grover wrote:
> We now require that the userspace handler set a bit if the command is not
> handled.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
> Documentation/target/tcmu-design.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/target/tcmu-design.txt b/Documentation/target/tcmu-design.txt
> index c80bf1e..032494f 100644
> --- a/Documentation/target/tcmu-design.txt
> +++ b/Documentation/target/tcmu-design.txt
> @@ -339,8 +339,12 @@ int handle_device_events(int fd, void *map)
> ent->rsp.scsi_status = SCSI_CHECK_CONDITION;
> }
> }
> + else if (tcmu_hdr_get_op(&ent->hdr) != TCMU_OP_PAD) {
Hi Andy,
This should be 'tcmu_hdr_get_op(ent->hdr.len_op)' right?
This also needs to be changed in the if statement above.
Cheers,
Ilias
> + /* Tell the kernel we didn't handle unknown opcodes */
> + ent->hdr.uflags |= TCMU_UFLAG_UNKNOWN_OP;
> + }
> else {
> - /* Do nothing for PAD entries */
> + /* Do nothing for PAD entries except update cmd_tail */
> }
>
> /* update cmd_tail */
> --
> 2.1.0
Attachment:
signature.asc
Description: Digital signature
