On Sat, May 02, 2015 at 06:01:03PM -0700, Nicholas A. Bellinger wrote:
> I want to keep the ability for individual backends to define their own
> attributes at runtime.
>
> That said, I'd rather move the original two types (IBLOCK, FILEIO,
> RAMDISK type + PSCSI type) into a common set of macros to reduce
> duplication, but still leave enough flexibility for new TCMU attributes
> or a future NVMe backend driver.
I think there is two cases to considere here:
(1) a backend or set of backends with a very different set of attributes.
These should have a new transport_type assigned and a different set
of attributes in the core
(2) a backend adding additional attributes. Just like in the fabric
driver case we should define new attribute groups to add them.
Even with these patches we're ready for (1), and (2) will require a
bit of work when needed. But at the same time we have a huge reduction
in code size and complexity, and a even bigger reduction in binary size
and a much cleaner interface right now.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
