Re: [PATCH] target/user: Disallow pass_level=0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 30, 2015 at 11:14:27AM -0700, Andy Grover wrote:
> TCMU requires more work to correctly handle both user handlers that want
> all SCSI commands (pass_level=0) for a se_device, and also handlers that
> just want I/O commands and let the others be emulated by the kernel
> (pass_level=1).
> 
> Right now, TCMU is doing the right thing for level=1, but attributes and
> transport_type are wrong for level=0. Do not allow it to be used for now.
> We can resolve the issues and then enable it when it's ready.
> 
> The ABI break for TCMU v2 is already applied for this release, so it's
> best to include this now to avoid another ABI break in the future.

Should we just remove the pass_level option for tcmuv2 entirely?
As mentioned in the earlier analysis I don't think this can be made
to work without a second se_subsystem_api regiration, and not selected
on an already existing configfs object.

If for some reason we will be able to add this as a runtime attribute
I'd prefer to have a more descriptive name than the rather nondescript
pass_level.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux