On Mon, 2015-04-20 at 15:00 +0200, Christoph Hellwig wrote: > Drivers may override the WCE flag, in which case the DPOFUA flag in > MODE SENSE might differ from the check used to reject invalid FUA > bits in sbc_check_dpofua. Also now that we reject invalid FUA > bits early there is no need to duplicate the same buggy check > down in the fileio code. > > As the DPOFUA flag controls th support for FUA bits on read and > write commands as well as DPO key off all the checks off a single > helper, and deprecate the emulate_dpo and emulate_fua_read attributs. > > This fixes various failures in the libiscsi testsuite. > > Personally I'd prefer to also remove the emulate_fua_write attribute > as there is no good reason to disable it, but I'll leave that for > a separate discussion. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/target/target_core_device.c | 30 +++++++----------------------- > drivers/target/target_core_file.c | 4 +--- > drivers/target/target_core_internal.h | 2 ++ > drivers/target/target_core_sbc.c | 6 +++--- > drivers/target/target_core_spc.c | 25 ++++++++----------------- > drivers/target/target_core_transport.c | 19 +++++++++++++++++++ > include/target/target_core_base.h | 6 ------ > 7 files changed, 40 insertions(+), 52 deletions(-) > Applied to for-next, with a bit of fuzz due to commit 9bc6548f. Thanks HCH. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
