Re: [PATCH v3 2/5] lib: introduce crc_t10dif_update()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-04-29 at 08:49 +0800, Herbert Xu wrote:
> On Tue, Apr 28, 2015 at 10:38:36AM -0700, Tim Chen wrote:
> >
> > +       if (update) {
> > +               err = crypto_shash_import(&desc.shash, &crc);   
> > +               BUG_ON(err);
> 
> You don't even have to make this conditional.  Just always do
> the import since it's just doing a memcpy anyway.
> 

Cool, this will simplify things more :)

Tim


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux