Andy Grover wrote: > On 04/12/2015 07:17 AM, Sebastian Herbszt wrote: > > Add target hooks. > > > > Signed-off-by: Sebastian Herbszt <herbszt@xxxxxx> > > > +#ifdef LPFC_TARGET_MODE > > +#include "lpfc_target_api.h" > > +#include "lpfc_target_api_base.h" > > +#endif > > Hi, great to see new fabrics posted. The code is actually not new. This is just yet another attempt to get it upstream [1]. > There are a great many ifdefs like this. Are they strictly necessary? None should be necessary. I left them in to allow an easy way to test the code without impact on the initiator part of lpfc. > Thanks -- Regards -- Andy [1] http://www.spinics.net/lists/kernel/msg1060127.html Sebastian -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
