On Tue, 2015-04-14 at 21:30 +0200, Christoph Hellwig wrote: > On Tue, Apr 14, 2015 at 01:26:06PM +0200, Bart Van Assche wrote: > > The loop in core_tmr_abort_task() iterates over sess_cmd_list. > > That list is a list of regular commands and task management > > functions (TMFs). Skip TMFs in this loop instead of letting > > the target drivers filter out TMFs in their get_task_tag() > > callback function. > > This looks like a good safety check, I wonder how the non-qla2xxx fabric > drivers managed to get away without this so far. > Because tcm_qla2xxx is the only fabric driver that uses container_of() on se_cmd to obtain it's internal TMR or command descriptor depending on SCF_SCSI_TMR_CDB. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
