Re: [PATCH] ib_srpt: Remove set-but-not-used variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/14/2015 2:15 PM, Bart Van Assche wrote:
Detected these variables by building with W=1.

Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
---
  drivers/infiniband/ulp/srpt/ib_srpt.c | 9 ---------
  1 file changed, 9 deletions(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index e45a0c3..86b0a0a 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -1388,7 +1388,6 @@ static void srpt_handle_send_err_comp(struct srpt_rdma_ch *ch, u64 wr_id)
  {
  	struct srpt_send_ioctx *ioctx;
  	enum srpt_command_state state;
-	struct se_cmd *cmd;
  	u32 index;

  	atomic_inc(&ch->sq_wr_avail);
@@ -1396,7 +1395,6 @@ static void srpt_handle_send_err_comp(struct srpt_rdma_ch *ch, u64 wr_id)
  	index = idx_from_wr_id(wr_id);
  	ioctx = ch->ioctx_ring[index];
  	state = srpt_get_cmd_state(ioctx);
-	cmd = &ioctx->cmd;

  	WARN_ON(state != SRPT_STATE_CMD_RSP_SENT
  		&& state != SRPT_STATE_MGMT_RSP_SENT
@@ -1473,10 +1471,8 @@ static void srpt_handle_rdma_err_comp(struct srpt_rdma_ch *ch,
  				      struct srpt_send_ioctx *ioctx,
  				      enum srpt_opcode opcode)
  {
-	struct se_cmd *cmd;
  	enum srpt_command_state state;

-	cmd = &ioctx->cmd;
  	state = srpt_get_cmd_state(ioctx);
  	switch (opcode) {
  	case SRPT_RDMA_READ_LAST:
@@ -2179,12 +2175,9 @@ static void srpt_destroy_ch_ib(struct srpt_rdma_ch *ch)
   */
  static void __srpt_close_ch(struct srpt_rdma_ch *ch)
  {
-	struct srpt_device *sdev;
  	enum rdma_ch_state prev_state;
  	unsigned long flags;

-	sdev = ch->sport->sdev;
-
  	spin_lock_irqsave(&ch->spinlock, flags);
  	prev_state = ch->state;
  	switch (prev_state) {
@@ -3648,12 +3641,10 @@ err:
  static void srpt_drop_nodeacl(struct se_node_acl *se_nacl)
  {
  	struct srpt_node_acl *nacl;
-	struct srpt_device *sdev;
  	struct srpt_port *sport;

  	nacl = container_of(se_nacl, struct srpt_node_acl, nacl);
  	sport = nacl->sport;
-	sdev = sport->sdev;
  	spin_lock_irq(&sport->port_acl_lock);
  	list_del(&nacl->list);
  	spin_unlock_irq(&sport->port_acl_lock);


Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux