On Wed, Apr 08, 2015 at 09:58:09AM +0200, Bart Van Assche wrote: > Hello Christoph, > > To me this looks like a significant step forward. However, I think this > approach can be taken even further. How about making the following > additional changes: > - Eliminate port_acl_list from the ib_srpt driver. This is possible by > changing the single srpt_lookup_acl() call into a call of > core_tpg_check_initiator_node_acl(). I can implement this if you prefer. Yes, please send a separate patch for this on top of mine. This patch already is huge, and I'll probably need to split at least a few bits out of it anyway when rebasing it. > - Modify the second argument of the get_pr_transport_id() callback from > struct se_node_acl * into the initiator port name. That port name is namely > the only information used by the get_pr_transport_id() callback functions. This sounds like a good start, but I'd actually prefer to go one step further: - add a protocol identifier field to the target template instead of the .get_fabric_proto_ident method. - provide a default implementation of .tpg_get_pr_transport_id, .tpg_get_pr_transport_id_len and .tpg_parse_pr_out_transport_id in the core instead of all the duplicate switch tables. - have default implementations in the core of ->get_pr_transport_id, -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
