On Wed, 2015-04-01 at 12:32 -0700, Andy Grover wrote: > On 04/01/2015 12:07 AM, Nicholas A. Bellinger wrote: > > Hi Andy, > > > > On Tue, 2015-03-31 at 15:04 -0700, Andy Grover wrote: > >> Before 4.0, reading attrib/emulate_fua_write has returned 1. Saved > >> configs created on a pre-4.0 kernel will try to write that back when > >> restoring LIO configuration. This should succeed with no effect, > >> and issue a warning. > >> > >> See https://bugzilla.redhat.com/show_bug.cgi?id=1206184 > >> > >> Reported-by: Yanko Kaneti <yaneti@xxxxxxxxxxx> > >> Reported-by: Juan Quintela <quintela@xxxxxxxxxx> > >> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> > >> --- > >> drivers/target/target_core_device.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > >> index 79b4ec3..7faa6ae 100644 > >> --- a/drivers/target/target_core_device.c > >> +++ b/drivers/target/target_core_device.c > >> @@ -781,8 +781,8 @@ int se_dev_set_emulate_fua_write(struct se_device *dev, int flag) > >> } > >> if (flag && > >> dev->transport->get_write_cache) { > >> - pr_err("emulate_fua_write not supported for this device\n"); > >> - return -EINVAL; > >> + pr_warn("emulate_fua_write not supported for this device, ignoring\n"); > >> + return 0; > >> } > >> if (dev->export_count) { > >> pr_err("emulate_fua_write cannot be changed with active" > > > > This patch does not apply against target-pending/for-next code. > > > > Note this particular check was already dropped in >= v3.19-rc1: > > > > target: Drop left-over PHBA_PDEV set attr checks > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/target/target_core_device.c?id=4b2f57e5ced40e91cbf8886d7dc40a9474d2f5c0 > > This patch is against Linus's tree. > > 4b36b68ca8bab6edf7e99f859c42a91f3ad1846e in v4.0-rc5 seems to re-add > these checks to set_emulate_fua_write...? I'm confused. That one check > wasn't mentioned in the changelog, did it sneak in? > Ah, yes of course. In that case, I'll apply this to target-pending/master, and include it in the v4.0-rc7 fixes PULL request going out over the next days. Thanks for clarifying. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
