On Tue, 2015-03-31 at 10:43 -0700, Andy Grover wrote: > "The domainname can be specified as either a DNS host name, a > dotted-decimal IPv4 address, or a bracketed IPv6 address as specified > in [RFC2732]." > > See https://bugzilla.redhat.com/show_bug.cgi?id=1206868 > > Reported-by: Kyle Brantley <kyle@xxxxxxxxxxxxxx> > Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> > --- Applied to target-pending/for-next. Thanks Kyle & Andy! --nab > drivers/target/iscsi/iscsi_target.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > index cd611e7..8cd684a 100644 > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -3460,6 +3460,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, > tpg_np_list) { > struct iscsi_np *np = tpg_np->tpg_np; > bool inaddr_any = iscsit_check_inaddr_any(np); > + char *fmt_str; > > if (np->np_network_transport != network_transport) > continue; > @@ -3487,8 +3488,12 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, > } > } > > - len = sprintf(buf, "TargetAddress=" > - "%s:%hu,%hu", > + if (np->np_sockaddr.ss_family == AF_INET6) > + fmt_str = "TargetAddress=[%s]:%hu,%hu"; > + else > + fmt_str = "TargetAddress=%s:%hu,%hu"; > + > + len = sprintf(buf, fmt_str, > inaddr_any ? conn->local_ip : np->np_ip, > np->np_port, > tpg->tpgt); -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
