Re: [PATCH v2 1/1] target: do not reject FUA CDBs when write cache is enabled but emulate_write_cache is 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christophe,

On Thu, 2015-03-19 at 14:30 +0100, Christophe Vu-Brugier wrote:
> A check that rejects a CDB with FUA bit set if no write cache is
> emulated was added by the following commit:
> 
>   fde9f50 target: Add sanity checks for DPO/FUA bit usage
> 
> The condition is as follows:
> 
>   if (!dev->dev_attrib.emulate_fua_write ||
>       !dev->dev_attrib.emulate_write_cache)
> 
> However, this check is wrong if the backend device supports WCE but
> "emulate_write_cache" is disabled.
> 
> This patch uses se_dev_check_wce() (previously named
> spc_check_dev_wce) to invoke transport->get_write_cache() if the
> device has a write cache or check the "emulate_write_cache" attribute
> otherwise.
> 
> Signed-off-by: Christophe Vu-Brugier <cvubrugier@xxxxxxxxxxx>

Thanks alot for fixing this regression.

Applied to target-pending/master, and will be included in the next
v4.0-rc fixes PULL request.

Thank you,

--nab


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux