On Feb 3, 2015, at 4:55 AM, Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> wrote:
> On 1/30/2015 11:50 PM, Nicholas A. Bellinger wrote:
>
>>> if (!text_in) {
>>> - pr_err("Unable to locate text_in buffer for sendtargets"
>>> - " discovery\n");
>>> - goto reject;
>>> + if (conn->sess->sess_ops->SessionType) {
>>> + /* Assume this is a consecutive sendtargets */
>>> + cmd->cmd_flags |= IFC_SENDTARGETS_ALL;
>>> + cmd->targ_xfer_tag = be32_to_cpu(hdr->ttt);
>>> + goto empty_sendtargets;
>>> + } else {
>>> + pr_err("Unable to locate text_in buffer for sendtargets"
>>> + " discovery\n");
>>> + goto reject;
>>> + }
>>
>> Btw, why is this restricted to SessionType=Discovery..? AFAICT it
>> should work as expected for SessionType=Normal as well, no..?
>
> I guess it can, but is the initiator allowed to send us sendtargets
> request in a normal session? I assume this is IFC_SENDTARGETS_ALL
> (although I guess I don't need to assume that if I locate the cmd from
> the hdr->tty).
It says you can send SendTargets discovery sessions and in “operational sessions”. For the latter, you just info for the target you are connected to.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
