On Mon, 2015-01-26 at 12:49 +0200, Sagi Grimberg wrote: > No reason to allocate a buffer of size bigger than initiator > MaxRecvDataSegmentLength. Moreover, we need to respect initiator > MRDSL and not send a larger payload. > > Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> > --- > drivers/target/iscsi/iscsi_target.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > index 866f9fe..0a1c3c0 100644 > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -3397,7 +3397,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, > unsigned char buf[ISCSI_IQN_LEN+12]; /* iqn + "TargetName=" + \0 */ > unsigned char *text_in = cmd->text_in_ptr, *text_ptr = NULL; > > - buffer_len = max(conn->conn_ops->MaxRecvDataSegmentLength, > + buffer_len = min(conn->conn_ops->MaxRecvDataSegmentLength, > SENDTARGETS_BUF_LIMIT); > > payload = kzalloc(buffer_len, GFP_KERNEL); Applied to target-pending/for-next. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
