Re: [PATCH] iscsi-target: nullify session in failed login sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-12-15 at 15:08 +0200, Sagi Grimberg wrote:
> In case login sequence failed, make sure conn->sess is
> NULL before calling wait_conn as some transports (iser)
> may rely on that (waiting for session commands).
> 
> Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> ---
>  drivers/target/iscsi/iscsi_target_login.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 18e2601..713c0c1 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -1159,6 +1159,7 @@ void iscsi_target_login_sess_out(struct iscsi_conn *conn,
>  	}
>  	kfree(conn->sess->sess_ops);
>  	kfree(conn->sess);
> +	conn->sess = NULL;
>  
>  old_sess_out:
>  	iscsi_stop_login_thread_timer(np);

Hey Sagi,

This patch should be squashed into the commit already tagged for stable:

   954f237 iscsi,iser-target: Initiate termination only once

that adds ->wait_conn() into iscsi_target_login_sess_out(), right..?

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux