On 12/2/2014 3:28 PM, Or Gerlitz wrote:
On 12/2/2014 1:07 PM, Sagi Grimberg wrote:
On 12/2/2014 12:19 PM, Or Gerlitz wrote:
On 12/1/2014 7:50 PM, Sagi Grimberg wrote:
In order to know that we consumed all the connection completions
we maintain atomic post_send_buf_count for each IO post send. But
we can know that if we post a "beacon" (zero length RECV work request)
after we move the QP into error state and the target does not serve
any new IO. When we consume it, we know we finished all the connection
completion and we can go ahead and destroy stuff.
oops, this patch contains many changes not directly related to the
change-log, I guess t either happened by mistake,
or we need splitting to 1-2 more patches,
It's not by mistake, what changes are not related to the change log?
e.g removing/delaing with
isert_conn->conn_wait_comp_err
care to explain? How would you split it?
If not splitting it, @ least explaining it... I don't see why the
removal of isert_conn->conn_wait_comp_err is natural part of this patch,
please explain it in the change-log for the sake of review and maintenance.
OK, I'll address that.
Thanks Or for the detailed feedback.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
