Re: [PATCH v2 05/34] iser-target: Reject connect request in failure path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/2/2014 12:42 PM, Or Gerlitz wrote:
On 12/1/2014 7:49 PM, Sagi Grimberg wrote:
And change log level of a relevant print.

Cc: <stable@xxxxxxxxxxxxxxx> # 3.10+
Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
---
  drivers/infiniband/ulp/isert/ib_isert.c |    5 ++++-
  1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp/isert/ib_isert.c
index 3977f2e..f859c24 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -685,8 +685,9 @@ isert_connect_request(struct rdma_cm_id *cma_id,
struct rdma_cm_event *event)
      list_add_tail(&isert_conn->conn_accept_node,
&isert_np->np_accept_list);
      mutex_unlock(&isert_np->np_accept_mutex);
-    pr_debug("isert_connect_request() up np_sem np: %p\n", np);
+    pr_info("np %p: Allow accept_np to continue\n", np);
      up(&isert_np->np_sem);
+
      return 0;
  out_conn_dev:
@@ -705,6 +706,8 @@ out_login_buf:
      kfree(isert_conn->login_buf);
  out:
      kfree(isert_conn);
+    rdma_reject(cma_id, NULL, 0);
+
      return ret;
  }

This patch introduces one functional change (add call to rdma_reject)
which can be (and should be) one liner!

It add two blank lines and changes another print

please avoid that here and elsewhere (specifically adding/deleting blank
lines just for nothing)

Fixed.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux