Re: [PATCH 1/1] Conform to RFC 3720.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014-11-06 09:18 skrev Jerome Martin:
Note that you might want to have a To: and/or Reply-to: header in the
emails you send

Ok, thanx. This was the first time I used git format-patch and send-email. I usually
do all my pull requests etc via GitHub...

It does not "nullify" anything, it merely does not preserve the initial formatting.

Isn't that 'nullifying'? Enforcing/creating a lowercased only from something that shouldn't
be considered?

Since I do not change the case in my application, I can no longer use the lio-utils commands (lio-node is the only one I've tested so far). It croaks when trying to do anything, because
it can't find the lower cased IQN dir...

RFC3720 states IQN is _not_ case sensitive.

And yet 'you' MAKES it case sensitive (by changing it)...

The decision to normalize to lower-case only was taken because of non-RFC 3720 initiators that were spotted in the wild, causing issues: these were choking up
when the IQN contained mixed case.

That's bad news... I might have to reconsider my own app here..

How about making this configurable? Say, setting a variable LIO_USE_LOWER_CASE=0 (or whatever :) and if that's set, then don't lower case everything? If you want to mainain the current behaviour. I would argue to do it the other way around (conform to the RFC first, and if someone doesn't want/like that - because of broken initiators,
then change the case to work with them).

I think it was a windows initiator problem at the time, but am not 100% positive.

Why am I not surprised!? :)

Remove these, to conform to the RFC.

I fail to see how using an equivalent notation for those IQNs
(according to the RFC) is non conforming to the RFC.

Because if an (my) application conforms to the RFC (and allows mixed case IQNs), the lio-utils commands doesn't work (because of the mixed case)... Hence, it suddenly
IS/becomes case sensitive...
--
... but you know as soon as Oracle starts waving its wallet at a Company it's time to run - fast.
/illumos mailing list
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux