Re: [PATCH] srp-target: Rertry when QP creation fails with ENOMEM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/2014 8:24 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-10-19 at 18:05 +0300, Sagi Grimberg wrote:
From: Bart Van Assche <bvanassche@xxxxxxx>

Retry with srp_sq_size/2.

Reported-by: Mark Lehrer <lehrer@xxxxxxxxx>
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
---
  drivers/infiniband/ulp/srpt/ib_srpt.c |    8 ++++++++
  1 files changed, 8 insertions(+), 0 deletions(-)

Applied to target-pending/queue.  Thanks Bart + Sagi!

A more detailed commit log and/or comment would be helpful to include
for master on this one..


How about:

It is not guaranteed to that srp_sq_size is supported
by the HCA. So if we failed to create the QP with ENOMEM,
try with a smaller srp_sq_size. Keep it up until we hit
MIN_SRPT_SQ_SIZE, then fail the connection.

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux