Hi Steve, On Wed, 2014-10-15 at 10:59 -0700, Steven Allen wrote: > The fact that a target is published on the any address has no bearing on > which port(s) it is published. SendTargets should always send the > portal's port, not the port used for discovery. > --- > drivers/target/iscsi/iscsi_target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > index 260c3e1..ad85abe 100644 > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -3491,7 +3491,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, > len = sprintf(buf, "TargetAddress=" > "%s:%hu,%hu", > inaddr_any ? conn->local_ip : np->np_ip, > - inaddr_any ? conn->local_port : np->np_port, > + np->np_port, > tpg->tpgt); > len += 1; > Nice catch on this sendtargets discovery typo! Applied to target-pending/queue. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
