On Tue, 2014-09-02 at 17:50 -0400, Joern Engel wrote: > Clearly a right-shift was meant. Effectively doesn't make a difference, > as add_len is hard-coded to 8 and the high byte will be zero no matter > which way you shift. But I hate leaving bad examples for others to > copy. > > Found by coverity. > > Signed-off-by: Joern Engel <joern@xxxxxxxxx> > --- > drivers/target/target_core_pr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c > index df357862286e..281d52e3fe99 100644 > --- a/drivers/target/target_core_pr.c > +++ b/drivers/target/target_core_pr.c > @@ -3803,7 +3803,7 @@ core_scsi3_pri_report_capabilities(struct se_cmd *cmd) > if (!buf) > return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; > > - buf[0] = ((add_len << 8) & 0xff); > + buf[0] = ((add_len >> 8) & 0xff); > buf[1] = (add_len & 0xff); > buf[2] |= 0x10; /* CRH: Compatible Reservation Hanlding bit. */ > buf[2] |= 0x08; /* SIP_C: Specify Initiator Ports Capable bit */ Applied to target-pending/for-next. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
