Re: [PATCH 08/16] target: avoid NULL pointer dereference

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Tue, 2014-09-02 at 17:49 -0400, Joern Engel wrote:
> iscsi_release_param_list() cannot handle a NULL pointer.  Found by
> coverity.
> 
> Signed-off-by: Joern Engel <joern@xxxxxxxxx>
> ---
>  drivers/target/iscsi/iscsi_target_parameters.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c
> index 02f9de26f38a..18c29260b4a2 100644
> --- a/drivers/target/iscsi/iscsi_target_parameters.c
> +++ b/drivers/target/iscsi/iscsi_target_parameters.c
> @@ -601,7 +601,7 @@ int iscsi_copy_param_list(
>  	param_list = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL);
>  	if (!param_list) {
>  		pr_err("Unable to allocate memory for struct iscsi_param_list.\n");
> -		goto err_out;
> +		return -1;
>  	}
>  	INIT_LIST_HEAD(&param_list->param_list);
>  	INIT_LIST_HEAD(&param_list->extra_response_list);

Applied to target-pending/master, with a CC' to stable for v3.1.y.

Thanks Joern!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html