Hi Sebastian, Apologies for the long delayed response, comments are inline below. On Sat, 2014-08-30 at 00:31 +0200, Sebastian Herbszt wrote: > Return user data segment multiplier instead of user data segment size. > > Signed-off-by: Sebastian Herbszt <herbszt@xxxxxx> > > diff -urp a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c > --- a/drivers/target/target_core_spc.c 2014-08-28 04:54:09.970917436 +0200 > +++ b/drivers/target/target_core_spc.c 2014-08-28 04:55:16.014913879 +0200 > @@ -664,7 +664,7 @@ spc_emulate_evpd_b3(struct se_cmd *cmd, > buf[0] = dev->transport->get_device_type(dev); > buf[3] = 0x0c; > put_unaligned_be32(dev->t10_alua.lba_map_segment_size, &buf[8]); > - put_unaligned_be32(dev->t10_alua.lba_map_segment_size, &buf[12]); > + put_unaligned_be32(dev->t10_alua.lba_map_segment_multiplier, &buf[12]); > > return 0; > } Thanks, applied to target-pending/master. Also, adding Hannes to the CC', as this was his code. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html