Found by coverity. l_conn cannot possible be NULL. It can very well not match any connection, which is the logical equivalent of NULL. At that point we would happily dereference the pointer and do heck knows what with the random values we find. A NULL pointer dereference would have been much better. Signed-off-by: Joern Engel <joern@xxxxxxxxx> --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 30f4a7d42e32..f9d2b1255856 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4549,7 +4549,7 @@ static void iscsit_logout_post_handler_diffcid( } spin_unlock_bh(&sess->conn_lock); - if (!l_conn) + if (&l_conn->conn_list == &sess->sess_conn_list) return; if (l_conn->sock) -- 2.0.0.rc0.1.g7b2ba98 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
