On Tue, 2014-06-10 at 11:19 +0530, Tejas Vaykole wrote: > Hi, > On 6/6/2014 6:50 AM, Nicholas A. Bellinger wrote: > > Hi Tejas, > > > > On Thu, 2014-06-05 at 15:40 +0530, Tejas Vaykole wrote: > >> Hi, > >> The iSCSI target is expected to send a Login reject when it receives the > >> CHAP_C value which target or initiator > >> has used in previous attempts for authentication (as stated in RFC > >> 1994,section 4.1). However , > >> i find that LIO is accepting the reuse of CHAP_C values,and sends a > >> Login success which is an error. > >> RFC 1994 section 4.1 > >> -------------<snip>-------------- > >> The Challenge Value MUST be changed each time a Challenge is sent. > >> Originators MUST NOT reuse the CHAP > >> challenge sent by the Responder for the other direction of a > >> bidirectional authentication. Responders MUST > >> check for this condition and close the iSCSI TCP connection if it occurs. > >> -------------<snip>-------------- > >> > >> i have attached the pcap for the same. > >> > > Thanks for reporting. I'm applying the following patch to address this > > case. Please test + confirm. > I Have tested the patch on following test machine and it looks ok. > Thanks for confirming the patch. It's on the way to v3.16-rc1 with a CC' to stable now.. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
