Hi Nicholas, On Tue, 10 Jun 2014 15:18:01 -0700, Nicholas A. Bellinger wrote : > So one potential issue here.. > > Now that lba_check = true is set for SYNCHRONIZE_CACHE and causes the > fabric_max_sectors + hw_max_sectors checks to kick in from above, it's > possible for a SYNCHRONIZE_CACHE to fail when the sector size exceeds > these *_max_sectors checks. > > IIRC, this is why these checks where separate to begin with.. > > So instead of adding lba_check, how about adding a goto to jump to the > shared end_lba check, bypassing the two _*max_sectors checks..? Thank you for your explanation. > Here is an updated version of your original patch that is being applied > to target-pending/for-next now. > > Please review. Your "goto" version looks fine. Also, I tested your patches for SYNCHRONIZE and VERIFY and they work as expected: an out-of-range LBA + count triggers an error. Best regards, -- Christophe Vu-Brugier -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
