On Tue, 2014-06-10 at 17:53 +0200, Christophe Vu-Brugier wrote: > Signed-off-by: Christophe Vu-Brugier <cvubrugier@xxxxxxxx> > --- > drivers/target/target_core_sbc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c > index aaec147..3721bce 100644 > --- a/drivers/target/target_core_sbc.c > +++ b/drivers/target/target_core_sbc.c > @@ -918,6 +918,10 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) > break; > case VERIFY: > size = 0; > + sectors = transport_get_sectors_10(cdb); > + cmd->t_task_lba = transport_lba_32(cdb); > + if (cmd->t_task_lba || sectors) > + lba_check = true; > cmd->execute_cmd = sbc_emulate_noop; > break; > case REZERO_UNIT: Updating this one as well to use a goto instead of lba_check. Please review. Thanks! --nab >From 094bda4f4446fa7d8ad5224d04e229f13bfa4b7e Mon Sep 17 00:00:00 2001 From: Christophe Vu-Brugier <cvubrugier@xxxxxxxx> Date: Tue, 10 Jun 2014 17:53:22 +0200 Subject: [PATCH] target/sbc: Check that the LBA and number of blocks are correct in VERIFY This patch extracts LBA + sectors for VERIFY, and adds a goto check_lba to perform the end-of-device checking. (Update patch to drop lba_check usage - nab) Signed-off-by: Christophe Vu-Brugier <cvubrugier@xxxxxxxx> Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> --- drivers/target/target_core_sbc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index 56dfec8..68e7871 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -925,8 +925,10 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) break; case VERIFY: size = 0; + sectors = transport_get_sectors_10(cdb); + cmd->t_task_lba = transport_lba_32(cdb); cmd->execute_cmd = sbc_emulate_noop; - break; + goto check_lba; case REZERO_UNIT: case SEEK_6: case SEEK_10: -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
