Re: [PATCH v1] Target/iser: Fix a wrong dereference in case discovery session is over iser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-06-10 at 13:41 +0300, Sagi Grimberg wrote:
> In case the discovery session is carried over iser, we can't
> access the assumed network portal since the default portal is
> used. In this case we don't really need to allocate the fastreg
> pool, just prepare to the text pdu that will follow.
> 
> Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> Reported-by: Alex Tabachnik <alext@xxxxxxxxxxxx>
> ---
> Changes from v0:
> - Fixed wrong session dereference
> 
>  drivers/infiniband/ulp/isert/ib_isert.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 52c5ab8..8232d9a 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -1053,7 +1053,9 @@ isert_put_login_tx(struct iscsi_conn *conn, struct iscsi_login *login,
>  	}
>  	if (!login->login_failed) {
>  		if (login->login_complete) {
> -			if (isert_conn->conn_device->use_fastreg) {
> +			if (!conn->sess->sess_ops->SessionType &&
> +			    isert_conn->conn_device->use_fastreg) {
> +				/* Normal Session and fastreg is used */
>  				u8 pi_support = login->np->tpg_np->tpg->tpg_attrib.t10_pi;
>  
>  				ret = isert_conn_create_fastreg_pool(isert_conn,

Applied instead of -v0, with a CC' to v3.15.y stable.

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux