[PATCH 0/3] target: Fix ABORT_TASK response + session reset hang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>

Hi Thomas & Harry,

This series addresses the two bugs that are cause a hung task to occur
when a long-standing I/O completes after both a ABORT_TASK, followed by
a iscsi-session reset occur, but before the subsequent I/O completion
by the backend of the aborted task takes place.

This results in multiple waiters on se_cmd->t_transport_stop_comp, and
only the first ABORT_TASK wait_on_complete() to occur.  It also makes
sure that se_cmd descriptors associated with a TMR set CMD_T_ACTIVE
before dispatch to ensure that transport_wait_for_tasks() works as
expected for TMRs as well.

Finally, it fixes a iscsi-target specific bug where iscsi_queue_req
memory was being leaked during the same ABORT_TASK + session reset
case, causing a iscsi_qr_cache warning upon iscsi_target_mod unload.

Please test!

--nab

Nicholas Bellinger (3):
  target: Set CMD_T_ACTIVE bit for Task Management Requests
  target: Use complete_all for se_cmd->t_transport_stop_comp
  iscsi-target: Fix ABORT_TASK + connection reset iscsi_queue_req
    memory leak

 drivers/target/iscsi/iscsi_target.c    |    3 +--
 drivers/target/target_core_transport.c |   12 +++++++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux