On 5/20/2014 1:58 PM, Or Gerlitz wrote:
On 20/05/2014 13:56, Sagi Grimberg wrote:
should we call rdma_disconnect in DEVICE_REMOVAL as well?
yes, we do that in the initiator and it works well there, AFAIK
OK, I agree to that.
Nic, you want me to post a patch for that?
Alternatively you can just squash the below in:
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp/isert/ib_isert.c
index 27205fb..ea73ad6 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -829,8 +829,8 @@ isert_cma_handler(struct rdma_cm_id *cma_id, struct
rdma_cm_event *event)
break;
case RDMA_CM_EVENT_ADDR_CHANGE: /* FALLTHRU */
case RDMA_CM_EVENT_DISCONNECTED: /* FALLTHRU */
- disconnect = true;
case RDMA_CM_EVENT_DEVICE_REMOVAL: /* FALLTHRU */
+ disconnect = true;
case RDMA_CM_EVENT_TIMEWAIT_EXIT: /* FALLTHRU */
isert_disconnected_handler(cma_id, disconnect);
break;
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
